From 68dda17ac44c933fd584d11d0799fa88e74f4d94 Mon Sep 17 00:00:00 2001 From: marcel Date: Sun, 26 Jun 2022 21:05:09 +0200 Subject: [PATCH] Fritzbox rollover bug fixed. --- CHANGELOG.md | 18 ++++++++++++++++++ fritz-api.sh | 9 +++++++-- 2 files changed, 25 insertions(+), 2 deletions(-) create mode 100644 CHANGELOG.md diff --git a/CHANGELOG.md b/CHANGELOG.md new file mode 100644 index 0000000..2078f9a --- /dev/null +++ b/CHANGELOG.md @@ -0,0 +1,18 @@ +# Changelog + +All notable changes to this project will be documented in this file. + + Added : for new features. + Changed : for changes in existing functionality. + Deprecated: for soon-to-be removed features. + Removed : for now removed features. + Fixed : for any bug fixes. + Security : in case of vulnerabilities. + +## [1.0.0] - 2022-06-24 +First working version. + +## [1.0.1] - 2022-06-26 + +### Fixed +- Fritzbox roll over bug: downloaded/uploaded counters rolled over at about 4 GByte diff --git a/fritz-api.sh b/fritz-api.sh index 0f22bb2..0d45ea2 100755 --- a/fritz-api.sh +++ b/fritz-api.sh @@ -125,8 +125,13 @@ print_json(){ UPSTREAM=$(find_xml_value "${STATUS2}" NewLayer1UpstreamMaxBitRate) BANDWIDTHDOWNBYTES=$(find_xml_value "${STATUS3}" NewByteReceiveRate) BANDWIDTHUPBYTES=$(find_xml_value "${STATUS3}" NewByteSendRate) - TOTALBWDOWNBYTES=$(find_xml_value "${STATUS3}" NewTotalBytesReceived) - TOTALBWUPBYTES=$(find_xml_value "${STATUS3}" NewTotalBytesSent) + # NewByteReceiveRate and NewByteSendRate are 32 bit registers overflowing at 4.3*1e9 bytes + # Use the 64 bit registers instead: + # TOTALBWDOWNBYTES=$(find_xml_value "${STATUS3}" NewTotalBytesReceived) + # TOTALBWUPBYTES=$(find_xml_value "${STATUS3}" NewTotalBytesSent) + TOTALBWDOWNBYTES=$(find_xml_value "${STATUS3}" NewX_AVM_DE_TotalBytesReceived64) + TOTALBWUPBYTES=$(find_xml_value "${STATUS3}" NewX_AVM_DE_TotalBytesSent64) + if [ "${DEBUG}" -eq 1 ]; then echo "DEBUG - Status:" echo "$CONNECTIONSTATUS"